Skip to content

Reinstate NLS - #421

Open
fillods wants to merge 3 commits into
csete:masterfrom
fillods:reinstate_nls
Open

fillods wants to merge 3 commits into
csete:masterfrom
fillods:reinstate_nls

Conversation

@fillods

@fillods fillods commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Allow gettext support to be compiled in.

Allow gettext support to be compiled in.
@csete

csete commented Oct 10, 2026

Copy link
Copy Markdown
Owner

With commit 1423360 NLS is enabled again by default and seems to be working. Are any other changes are necessary for build or dependencies?

@fillods

fillods commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

To me, commit 1423360 is a quick and wrong way of fixing the issue. The define ENABLE_NLS should be handled by m4 macros (RTFM). Besides, these GETTEXT macros in configure.ac make sure the appropriate version of gettext is selected.

If you don't like the autopoint dependency, autogen.sh could be rewritten to use autoreconf altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants